Robert Millan <[EMAIL PROTECTED]> writes: >> > - movsbl %dh, %eax >> > - movl %eax, %ss:(DATA_ADDR + >> > GRUB_KERNEL_MACHINE_INSTALL_DOS_PART) >> > + // Check for the multiboot signature >> > + cmpl $0x1badb002, %ss:(DATA_ADDR + 0x50) >> > + jz 1f >> [...] >> >> if there is no objection, I'd like to check in this patch. > > I don't like that you hardcode 0x1badb002. Could you use the macro from > multiboot.h ? > > Also for the comments, I think /* */ is preferred (at least, it is consistent > with the rest of GRUB).
And do not forget "." :-) -- Marco _______________________________________________ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel
