> Here, please. This is for groff 1.19.2! Hope it applies cleanly to
> 1.21.
Thanks! Unfortunately, I believe that there are some errors in your
patch:
+++ e.tmac 2011-01-23 14:37:36.000000000 +0100
@@ -1039,13 +1039,18 @@
.de [3 \" --- article in book
.(f
.ip "\\*([F.\0"
-\\*([A, \\*(lq\\*([T,\\*(rq
Originally, as the last line shows, the title is typeset within
quotes. You change this...
-.if !"\\*([P"" pp. \\*([P
-in \\f2\\*([B\\f1, \c
-.if !"\\*([E"" ed. \\*([E, \c
-.if !"\\*([I"" \\*([I\c
+\\*([A\c
+.if !"\\*([T"" , \\f2\\*([T\\f1\c
to typeset the title with italics. Why? It's a basic design decision
of the -me macros to use quotes, and I don't want to change this
default.
Another problem: Your patch typesets the page number twice:
+.if !"\\*([P"" , pp. \\*([P\c <--- here
+ in \\f2\\*([B\\f1\c
+.if !"\\*([P"" \{.tr -\(en
+, S. \\*([P\c <--- here
+.tr -- \}
Note that `S.' is suitable for German only. [Have you really tested
whether this patch works?] Besides that, there is another bug: A test
is missing which uses number register `[P' to check whether to use
`p.' (for a single page) or `pp.' (for a page range). Look at the
definition of the `[1' macro; I think that the relevant code should be
duplicated.
BTW, I suggest to write `p.\~' or `pp.\~' to avoid situations like
This is some text on p.
3.
Now that I've looked into the details more closely, I could fix all of
this by myself. However, I think it's a good idea to make *you* learn
to fix it correctly :-)
Finally, I ask you to provide a proper ChangeLog entry.
Werner
