Em segunda-feira, 15 de maio de 2017 09:30:20 UTC-3, mhh...@gmail.com escreveu: > > On the code itself, > i suspect you don t know yet about *go fmt*, > I strongly suggest you to use it, > just because its a great idea. > > https://github.com/luisfurquim/ugarit/blob/master/epub20/book.go#L66 > This hurts :O *if (len(metatag)>0) {* > > Ok. Now it is go fmted! It also has fixed the extra parenthesis!
> See also go vet. > I'll check this soon. > https://github.com/luisfurquim/ugarit/blob/master/epub30/book.go#L126 > I don t think you need to init values here, see > https://play.golang.org/p/eN9cT9gQlE > > Ok! fixed. > https://github.com/luisfurquim/ugarit/blob/master/epub30/book.go#L137 > This kind of construction is redundant, en is the default value. > > Will check this soon > https://github.com/luisfurquim/ugarit/blob/master/epub30/book.go#L134 > This if *seems* useless > > When I applied some fixes the line numbering has made a few changes. The 'if' you a refering is the language handling one? If so, the language reference appears in more than one place in the EPub. So, I ask one specification and then set all of them. > https://github.com/luisfurquim/ugarit/blob/master/epub30/book.go#L456 > twice consecutive and identical conditions. > > I supose that you refer about the Manifest initialization which indeed was repetitive. Fixed > https://github.com/luisfurquim/ugarit/blob/master/epub30/book.go#L464 > I wonder. > I didn't get what is being pointed here. Maybe the line renumbering is confusing me here. Maybe you are pointing out the method naming? > > I must say you took great care about error values and documentation > ...I m a small player in comparison :p > > Thank you! > was it helpful ? I don't know. > > A lot! Thank you again! -- You received this message because you are subscribed to the Google Groups "golang-nuts" group. To unsubscribe from this group and stop receiving emails from it, send an email to golang-nuts+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
