HI, some feedback,
So this package generates epub files ? In versions 20 / 30 ? Is it correct ? Can you add an example to use it ? Small one. My very personal taste, I love useful READMEs. On the code itself, i suspect you don t know yet about *go fmt*, I strongly suggest you to use it, just because its a great idea. https://github.com/luisfurquim/ugarit/blob/master/epub20/book.go#L66 This hurts :O *if (len(metatag)>0) {* See also go vet. (generally speaking a good IDE will provide that for you, for example i use atom+go-plus: great) Then, lots of small things here and there, https://github.com/luisfurquim/ugarit/blob/master/epub30/book.go#L126 I don t think you need to init values here, see https://play.golang.org/p/eN9cT9gQlE https://github.com/luisfurquim/ugarit/blob/master/epub30/book.go#L137 This kind of construction is redundant, en is the default value. https://github.com/luisfurquim/ugarit/blob/master/epub30/book.go#L134 This if *seems* useless https://github.com/luisfurquim/ugarit/blob/master/epub30/book.go#L258 I did not get why options is a param of type interface{}, within the method body it might *only* be an *EPubOptions. Can it be a param of type *EPubOptions directly ? https://github.com/luisfurquim/ugarit/blob/master/epub30/book.go#L456 twice consecutive and identical conditions. https://github.com/luisfurquim/ugarit/blob/master/epub30/book.go#L464 I wonder. https://github.com/luisfurquim/ugarit/blob/master/epub30/book.go#L487 take advantage of filepath.Join() + os.Separator ? maybe. https://github.com/luisfurquim/ugarit/blob/master/epub30/book.go#L626 why 59? I must say you took great care about error values and documentation ...I m a small player in comparison :p was it helpful ? I don't know. On Sunday, May 14, 2017 at 10:49:44 PM UTC+2, Luis Furquim wrote: > > Hello Gophers! > > I am publishing a first barely usable version of an EPub eBook generator. > It still has many improvements to be done. Documentation is poor but > exists. There's an example in the epub30 package. Criticism would be a > great help. I know it has much to be done. So, please be gentle! ;) > > Thank you all! > Luis Otavio de Colla Furquim > -- You received this message because you are subscribed to the Google Groups "golang-nuts" group. To unsubscribe from this group and stop receiving emails from it, send an email to golang-nuts+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
