timsaucer commented on PR #19234: URL: https://github.com/apache/datafusion/pull/19234#issuecomment-3636894568
Sorry, I should be more clear. We use `serialize_physical_sort_exprs` which looks like it *is* included in the change here. It isn't a problem in the current `main` because that only has DefaultPhysicalExtensionCodec. If we make similar changes on the logical side as are proposed here or the physical side it will be a problem since we do not have concrete types as soon as we switch over to our FFI_LogicalExtensionCodec. Sorry for the brevity, trying to touch bases while at a work retreat. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
