milenkovicm commented on PR #19234:
URL: https://github.com/apache/datafusion/pull/19234#issuecomment-3634084565
I'm not sure, you stress me out with hard questions 😀
What if you change physical codec with only two methods
- deserialize_physical_expr
- serialize_physical_expr
```rust
fn deserialize_physical_expr(
&self,
proto: &protobuf::PhysicalExprNode,
ctx: &TaskContext,
input_schema: &arrow::datatypes::Schema,
) -> Result<Arc<dyn PhysicalExpr>> where Self: Sized {
from_proto::parse_physical_expr(proto, ctx, input_schema, self)
}
fn serialize_physical_expr(
&self,
expr: &Arc<dyn PhysicalExpr>,
) -> Result<protobuf::PhysicalExprNode> where Self: Sized {
to_proto::serialize_physical_expr(expr, self)
}
```
note `where Self: Sized` (compiler suggested i've followed) did not changed
anything else (this is on master)
Not sure if i missed something
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
