milenkovicm commented on PR #19234: URL: https://github.com/apache/datafusion/pull/19234#issuecomment-3636853180
The `PhysicalExtensionCodec` remains unchanged except for added methods for which no user action is required. It follows the same approach as the `LogicaExtensionCodec`. The public-facing methods still accept `&dyn PhysicalExtensionCodec`. I'm not sure if there will be huge performance implication of the change and if that even matters. Maybe as a follow up we should consider value of exposing `AsExecutionPlan` as public interface or we just keep from|to_bytes methos I need to verify one other bit if it is compatible with the ballista, (which I believe it does), but over all I do believe its solid proposal -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
