comphead commented on code in PR #2860:
URL: https://github.com/apache/datafusion-comet/pull/2860#discussion_r2601009072
##########
spark/src/main/scala/org/apache/comet/rules/CometExecRule.scala:
##########
@@ -258,11 +262,12 @@ case class CometExecRule(session: SparkSession) extends
Rule[SparkPlan] {
// Some execs that comet will not accelerate, such as command
execs.
op
case _ =>
- if (!hasExplainInfo(op)) {
+ if (op.children.forall(_.isInstanceOf[CometNativeExec]) &&
!hasExplainInfo(op)) {
Review Comment:
it would be nice having a comment on this construction that we expect
children/inputs to be native, every native node is `CometNativeExec`.
Previously it was clear as the construction was in separate method which was
commented
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
