andygrove commented on code in PR #2860: URL: https://github.com/apache/datafusion-comet/pull/2860#discussion_r2600456753
########## spark/src/test/resources/tpcds-plan-stability/approved-plans-v1_4-spark3_5/q28.native_iceberg_compat/extended.txt: ########## @@ -1,7 +1,7 @@ - BroadcastNestedLoopJoin [COMET: BroadcastNestedLoopJoin is not supported] -:- BroadcastNestedLoopJoin [COMET: BroadcastNestedLoopJoin is not supported] -: :- BroadcastNestedLoopJoin [COMET: BroadcastNestedLoopJoin is not supported] -: : :- BroadcastNestedLoopJoin [COMET: BroadcastNestedLoopJoin is not supported] +BroadcastNestedLoopJoin +:- BroadcastNestedLoopJoin +: :- BroadcastNestedLoopJoin +: : :- BroadcastNestedLoopJoin : : : :- BroadcastNestedLoopJoin [COMET: BroadcastNestedLoopJoin is not supported] Review Comment: The PR includes a fix to only show the first fallback in this case. We should not report fallbacks for operators when the child operator already fell back to Spark. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
