alamb commented on code in PR #19097:
URL: https://github.com/apache/datafusion/pull/19097#discussion_r2591064759


##########
datafusion/common/src/nested_struct.rs:
##########
@@ -54,31 +54,50 @@ fn cast_struct_column(
     target_fields: &[Arc<Field>],
     cast_options: &CastOptions,
 ) -> Result<ArrayRef> {
+    if source_col.data_type().is_null() {

Review Comment:
   what is really weird is that CastColumnExpr doesn't seem to be used anywhere 
other than tests 🤔 
   
   I could probably straight up delete that struct and have all the tests pass 
🤔 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to