alamb opened a new pull request, #19097: URL: https://github.com/apache/datafusion/pull/19097
## Which issue does this PR close? - Closes https://github.com/apache/datafusion/issues/17330 (and all subtasks I think) ## Rationale for this change @kosiew added struct aware casting in the following PR - https://github.com/apache/datafusion/pull/17773 However, that relies on a new physical `CastColumnExpr` that has a non trivial redundancy with `CastExpr`. Instead of relying on the new PhysicalExpr, I think we can upgrade `CastExpr` to handle structures ## What changes are included in this PR? 1. Consolidate `CastColumnExpr` with `CastColumn` 2. Remove `CastColumnExpr` I had codex do the first version for me, and it did quite a nice job ## Are these changes tested? Yes by CI ## Are there any user-facing changes? No ( -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
