brancz commented on code in PR #18981:
URL: https://github.com/apache/datafusion/pull/18981#discussion_r2581470081
##########
datafusion/common/src/hash_utils.rs:
##########
@@ -1323,4 +1477,127 @@ mod tests {
// 67 vs 67
assert_eq!(hashes[0], hashes[4]);
}
+
+ #[test]
+ #[cfg(not(feature = "force_hash_collisions"))]
+ fn create_hashes_for_sliced_run_array() -> Result<()> {
+ let values = Arc::new(Int32Array::from(vec![10, 20, 30]));
+ let run_ends = Arc::new(Int32Array::from(vec![2, 5, 7]));
+ let array = Arc::new(RunArray::try_new(&run_ends,
values.as_ref()).unwrap());
+
+ let random_state = RandomState::with_seeds(0, 0, 0, 0);
+ let mut full_hashes = vec![0; array.len()];
+ create_hashes(
+ &[Arc::clone(&array) as ArrayRef],
+ &random_state,
+ &mut full_hashes,
+ )?;
+
+ let array_ref: ArrayRef = Arc::clone(&array) as ArrayRef;
+ let sliced_array = array_ref.slice(2, 3);
+
+ let mut sliced_hashes = vec![0; sliced_array.len()];
+ create_hashes(
+ std::slice::from_ref(&sliced_array),
+ &random_state,
+ &mut sliced_hashes,
+ )?;
+
+ assert_eq!(sliced_hashes.len(), 3);
+ assert_eq!(sliced_hashes[0], sliced_hashes[1]);
+ assert_eq!(sliced_hashes[1], sliced_hashes[2]);
+ assert_eq!(sliced_hashes[0], full_hashes[2]);
+ assert_eq!(sliced_hashes[1], full_hashes[3]);
+ assert_eq!(sliced_hashes[2], full_hashes[4]);
+
+ Ok(())
+ }
+
+ #[test]
+ #[cfg(not(feature = "force_hash_collisions"))]
+ fn test_sliced_run_array_only_hashes_needed_values() -> Result<()> {
Review Comment:
actually I'm just going to remove this test, since the other test already
does that and also does a better job at it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
