vegarsti commented on code in PR #18981:
URL: https://github.com/apache/datafusion/pull/18981#discussion_r2576140159
##########
datafusion/common/src/hash_utils.rs:
##########
@@ -535,6 +636,10 @@ fn hash_single_array(
let array = as_union_array(array)?;
hash_union_array(array, random_state, hashes_buffer)?;
}
+ DataType::RunEndEncoded(_, _) => downcast_run_array! {
+ array => hash_run_array(array, random_state, hashes_buffer,
rehash)?,
+ _ => unreachable!()
Review Comment:
Okay, makes sense! Andrew has nudged me to return an error instead of
unreachable a couple of times, so I figured maybe it's a stance he takes
generally, that's why I remembered to comment on it. But if the dict case does
it, it makes sense to keep it!
(e.g. here, but I think that was slightly different
https://github.com/apache/arrow-rs/pull/8589#discussion_r2456085420)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
