iffyio commented on code in PR #2034:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/2034#discussion_r2371942961
##########
src/dialect/mod.rs:
##########
@@ -898,6 +898,12 @@ pub trait Dialect: Debug + Any {
false
}
+ /// Returns true if the dialect supports hint and C-style comments
+ /// e.g. `/*! hint */`
+ fn supports_c_style_comments(&self) -> bool {
Review Comment:
```suggestion
fn supports_c_style_comment_hints(&self) -> bool {
```
Since c_style comment I imagine is referring to `/**/` which other dialects
support?
##########
src/tokenizer.rs:
##########
@@ -4070,4 +4101,39 @@ mod tests {
panic!("Tokenizer should have failed on {sql}, but it succeeded
with {tokens:?}");
}
}
+ #[test]
+ fn tokenize_multiline_comment_with_c_style_comment() {
+ let sql = String::from("0/*! word */1");
Review Comment:
Ah so to clarify I'm rather wondering regarding the parser behavior for
hints that aren't singe words e.g. `/*!50110 KEY_BLOCK_SIZE=1024 */` - can we
demonstrate the behavior with test cases for such scenarios?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
