iffyio commented on code in PR #2034:
URL: 
https://github.com/apache/datafusion-sqlparser-rs/pull/2034#discussion_r2419919402


##########
src/dialect/mod.rs:
##########
@@ -898,6 +898,12 @@ pub trait Dialect: Debug + Any {
         false
     }
 
+    /// Returns true if the dialect supports hint and C-style comments
+    /// e.g. `/*! hint */`
+    fn supports_c_style_hints(&self) -> bool {

Review Comment:
   Ah to clarify the suggested change, c-style comment I think is rather 
understood as  `/* */` - i.e. multiline comment in general, the feature here I 
think is the optimizer hints within comments as mysql calls them



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to