alamb commented on code in PR #17592:
URL: https://github.com/apache/datafusion/pull/17592#discussion_r2359961397
##########
datafusion/physical-plan/src/aggregates/group_values/multi_group_by/mod.rs:
##########
@@ -578,11 +624,33 @@ impl<const STREAMING: bool> GroupValuesColumn<STREAMING> {
}
let iter = self.group_values.iter_mut().zip(cols.iter());
- for (group_column, col) in iter {
- group_column.vectorized_append(
- col,
- &self.vectorized_operation_buffers.append_row_indices,
- )?;
+ if self
Review Comment:
I suggest putting this check into a function with a descriptive name,
something like
```rust
if let Some(start, length) = self.consecutive_row_indices() {
...
} else {
...
}
```
I think that would make the intent clearer
But this is not necessary for this PR
##########
datafusion/physical-plan/src/aggregates/group_values/multi_group_by/mod.rs:
##########
@@ -233,6 +261,11 @@ struct VectorizedOperationBuffers {
/// The `vectorized append` row indices buffer
append_row_indices: Vec<usize>,
+ /// If all the values in `append_row_indices` are consecutive
Review Comment:
```suggestion
/// If all the values in `append_row_indices` are consecutive.
/// This is updated by [`Self::add_append_row_index`]
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
