rluvaton commented on code in PR #17592:
URL: https://github.com/apache/datafusion/pull/17592#discussion_r2352445267
##########
datafusion/physical-plan/src/aggregates/group_values/multi_group_by/mod.rs:
##########
@@ -233,6 +251,16 @@ struct VectorizedOperationBuffers {
/// The `vectorized append` row indices buffer
append_row_indices: Vec<usize>,
+ /// The last row index in `append_row_indices`
+ ///
+ /// Will be None if `append_row_indices` is empty
+ last_append_row_index: Option<usize>,
+
+ /// If all the values in `append_row_indices` are continuous
+ /// i.e. `append_row_indices[i] + 1 == append_row_indices[i + 1]`
+ /// this is used to optimize the `vectorized_append` operation
+ are_row_indices_continuous: bool,
Review Comment:
updated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
