Jefffrey commented on PR #17501: URL: https://github.com/apache/datafusion/pull/17501#issuecomment-3292255183
> Assuming support for decimal32/64 is desirable, I think the best course of action is: > > 1. Initially - the SQL interface just won't support creating decimal32/64 columns. Merge this PR as-is (once we have arrow 56.1.0 for casting). > > 2. Open a separate PR to make the breaking change to the SQL interface, but only merge it closer to the next major release (51, should be late November). > > > We can also decide to merge this PR (with the addition of the SQL support and SLT tests) closer to the 51 release, but personally I feel like its better to at least have the basic support merged so its actually used, which will help us find other missing functionality or potential bugs. Steps 1 & 2 sound good, if we can merge the majority of decimal 32/64 work in this PR and isolate that specific SQL parsing change into a separate issue/PR so it would be easier to review & discuss (a presumably smaller PR) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
