AdamGS opened a new pull request, #17501: URL: https://github.com/apache/datafusion/pull/17501
## Which issue does this PR close? Closes #17489. ## Rationale for this change Since Arrow 56 and #16690, support has been added to the two smaller decimal variants. This PR tries to bring support to them on-par with the support for the bigger types. I've run into this issue when upgrading [Vortex](https://github.com/vortex-data/vortex/pull/4577) to use the upcoming release (50), one of our [benchmarks](https://github.com/apache/datafusion/compare/main...AdamGS:adamg/extended-decimal-support?expand=1) fails with: ``` Error during planning: Execution error: Function 'sum' user-defined coercion failed with "Execution error: Sum not supported for Decimal32(7, 2)" No function matches the given name and argument types 'sum(Decimal32(7, 2))'. You might need to add explicit type casts. Candidate functions: sum(UserDefined) ``` ## What changes are included in this PR? Adding support for handling decimal32/64 wherever other decimal types are handled. I've tried to use multiple search methods to find places where they matter, but there might be some matches/if conditions that make them hard to find. ## Are these changes tested? The testing strategy to some of these parts is unclear to me, both around SQL but also for aggregate functions like `SUM` and `AVG`. ## Are there any user-facing changes? Code that used to fail while reading some decimals should now work. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
