BlakeOrth commented on code in PR #17266: URL: https://github.com/apache/datafusion/pull/17266#discussion_r2308256808
########## datafusion-cli/src/object_storage.rs: ########## @@ -563,6 +563,592 @@ pub(crate) async fn get_object_store( Ok(store) } +pub mod instrumented { Review Comment: I've put this into its own module because with this addition I feel like `object_storage` has probably grown past the point of being a single file. It seems like it should probably become a directory with 2 sub-modules, but this change set is already getting large enough I didn't want to go making large organizational changes prior to review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org