alamb commented on PR #17266: URL: https://github.com/apache/datafusion/pull/17266#issuecomment-3215719941
> * I thought it would be beneficial to be able to entirely disable object store profiling and use the default, non-instrumented, implementation by default. Yes, I agree with this > I was planning on adding a CLI flag to enable the instrumented store. I think it would be ok to always use the "Instrumented Object REgistry" and then only pass back an instrumented object store if the profiling was enabled > * I haven't added any of the code around it yet, but I was going to the UX from [ That is perfect! > `\object_store_profiling summary` or `\object_store_profiling trace`. > The first would print just a simple summary of calls, similar to my suggestion in the initial issue, and the latter would print both the summary and the individual call details as we see here. how about something like this (maybe you can implement one of these, perhaps summary, as the intial PR and we can add the others afterwards) ```sql # Prints an object store summary at the end of all results, after the query executed \profile objectstore summary ``` ```sql # prints one line per object store request at the end of all results, after the query executed \profile objectstore trace ``` ```sql # prints one line per object store request when it happens (potentially in the middle of results) # this can be useful to understand how the requests happen over time \profile objectstore inline ``` > Any feedback on the above, or general code structure/implementation is obviously welcome as well, so let me know your thoughts. This code is obviously a minimally functional example, but I'd rather incorporate feedback early than need to re-work a bunch of stuff! Indeed -- makes total sense I -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
