friendlymatthew commented on code in PR #17242:
URL: https://github.com/apache/datafusion/pull/17242#discussion_r2302051640
##########
datafusion/datasource-parquet/src/source.rs:
##########
@@ -580,12 +616,12 @@ impl FileSource for ParquetSource {
self
}
- fn metrics(&self) -> &ExecutionPlanMetricsSet {
+ fn metrics_inner(&self) -> &ExecutionPlanMetricsSet {
&self.metrics
}
- fn file_source_statistics(&self, config: &FileScanConfig) -> Statistics {
- let statistics = config.file_source_projected_statistics.clone();
+ fn file_source_statistics(&self) -> Statistics {
+ let statistics = self.config.file_source_projected_statistics.clone();
Review Comment:
We can change the naming of
[file_source_projected_statistics](https://github.com/apache/datafusion/pull/17242#discussion_r2301993969),
but I don't think this is a strange pattern-- `FileScanConfig` holds various
file source related fields like `file_schema`
##########
datafusion/datasource-parquet/src/source.rs:
##########
@@ -580,12 +616,12 @@ impl FileSource for ParquetSource {
self
}
- fn metrics(&self) -> &ExecutionPlanMetricsSet {
+ fn metrics_inner(&self) -> &ExecutionPlanMetricsSet {
&self.metrics
}
- fn file_source_statistics(&self, config: &FileScanConfig) -> Statistics {
- let statistics = config.file_source_projected_statistics.clone();
+ fn file_source_statistics(&self) -> Statistics {
+ let statistics = self.config.file_source_projected_statistics.clone();
Review Comment:
We should change the naming of
[file_source_projected_statistics](https://github.com/apache/datafusion/pull/17242#discussion_r2301993969),
but I don't think this is a strange pattern-- `FileScanConfig` holds various
file source related fields like `file_schema`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
