friendlymatthew commented on code in PR #17242:
URL: https://github.com/apache/datafusion/pull/17242#discussion_r2301993969
##########
datafusion/datasource/src/file.rs:
##########
@@ -270,8 +293,29 @@ impl<T: FileSource + 'static> DataSource for T {
SchedulingType::Cooperative
}
- fn data_source_statistics(&self) -> Result<Statistics> {
- Ok(self.config().projected_stats(self.file_source_statistics()))
+ fn data_source_statistics(&self) -> Statistics {
+ let file_source_statistics = self.file_source_statistics();
Review Comment:
I don't love `data_source_statistics` and `file_source_statistics`, curious
if people had thoughts on better names here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
