2010YOUY01 commented on PR #17286: URL: https://github.com/apache/datafusion/pull/17286#issuecomment-3216216601
I think this change could not improve e2e performance: optimizations should be done on bottlenecks (those steps that are repeating millions of times in a query), this step only get executed 1 time per query, and it's bounded by the number of CPU core, so we'd better choose simplicity over performance. Besides, sorting small array is super fast thanks to compiler and hardware. Perhaps the original solution is faster. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
