adriangb commented on code in PR #17286:
URL: https://github.com/apache/datafusion/pull/17286#discussion_r2294234672
##########
datafusion/physical-plan/src/joins/hash_join.rs:
##########
@@ -255,21 +227,21 @@ impl SharedBoundsAccumulator {
/// (col0 >= p1_min0 AND col0 <= p1_max0 AND col1 >= p1_min1 AND col1 <=
p1_max1))
fn create_filter_from_partition_bounds(
&self,
- bounds: &[PartitionBounds],
+ bounds: &[Option<Vec<ColumnBounds>>],
) -> Result<Arc<dyn PhysicalExpr>> {
- if bounds.is_empty() {
+ if bounds.iter().all(|b| b.is_none()) {
Review Comment:
This is now more work
##########
datafusion/physical-plan/src/joins/hash_join.rs:
##########
@@ -115,34 +114,6 @@ impl ColumnBounds {
}
}
-/// Represents the bounds for all join key columns from a single partition.
-/// This contains the min/max values computed from one partition's build-side
data.
-#[derive(Debug, Clone)]
-struct PartitionBounds {
Review Comment:
I think keeping the struct is helpful from a readability perspective to
avoid nested vecs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
