ryanschneider commented on code in PR #1927:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1927#discussion_r2205650933
##########
src/dialect/mod.rs:
##########
@@ -1076,6 +1088,15 @@ pub trait Dialect: Debug + Any {
fn supports_comma_separated_drop_column_list(&self) -> bool {
false
}
+
+ /// Returns true if the dialect supports the passed in alias.
+ /// See [IsNotNullAlias].
+ fn supports_is_not_null_alias(&self, alias: IsNotNullAlias) -> bool {
Review Comment:
Ok @iffyio, in bf25f42 I followed the pattern of a couple other spots in
that fn and in the `Keyword::DEFAULT` handler I peek the next token, and if
it's a LParen then switch back to `ParserState::Normal` while parsing that.
I see a couple other spots where this function calls `parse_expr`:
- `ColumnOption::Materialized`
- `ColumnOption::Alias`
- `ColumnOption::Ephemeral`
- `ColumnOption::Check`
- `ColumnOption::Srid`
I'll be honest I'm not familiar with most of these, so will need to look to
see if any of them need the same treatment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
