iffyio commented on code in PR #1927:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1927#discussion_r2204886676
##########
src/dialect/mod.rs:
##########
@@ -1076,6 +1088,15 @@ pub trait Dialect: Debug + Any {
fn supports_comma_separated_drop_column_list(&self) -> bool {
false
}
+
+ /// Returns true if the dialect supports the passed in alias.
+ /// See [IsNotNullAlias].
+ fn supports_is_not_null_alias(&self, alias: IsNotNullAlias) -> bool {
Review Comment:
Right yeah seems its a bit tricky with the `NOT NULL`scenario in create
statements, the parser state looks clean but not sure if it can correctly
handle the different scenarios? thinking for example, the following if I
understand the syntax correctly should be equivalent:
```rust
verified_stmt("CREATE TABLE foo (abc INT DEFAULT (42 IS NOT NULL) NOT
NULL)");
verified_stmt("CREATE TABLE foo (abc INT DEFAULT (42 NOT NULL) NOT NULL)");
```
so that only setting the state once on the outer expression/clause wouldn't
be correct. not sure if there's a clean way that doesn't require an invasive
change here :thinking: it might indeed be that we need to explicitly configure
the parse_expr function depending on the context
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
