tglanz commented on code in PR #1954: URL: https://github.com/apache/datafusion-comet/pull/1954#discussion_r2191729850
########## native/spark-expr/src/bloom_filter/bit.rs: ########## @@ -0,0 +1,56 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +/// Similar to the `read_num_bytes` but read nums from bytes in big-endian order +/// This is used to read bytes from Java's OutputStream which writes bytes in big-endian +/// Reads `$size` of bytes from `$src`, and reinterprets them as type `$ty`, in +/// big-endian order. +/// This is copied and modified datafusion_comet::common::bit. +macro_rules! read_num_be_bytes { + ($ty:ty, $size:expr, $src:expr) => {{ + debug_assert!($size <= $src.len()); + let mut buffer = [0u8; std::mem::size_of::<$ty>()]; + buffer.as_mut()[..$size].copy_from_slice(&$src[..$size]); + <$ty>::from_be_bytes(buffer) + }}; +} + +/// Returns the ceil of value/divisor +#[inline] +pub fn ceil(value: usize, divisor: usize) -> usize { Review Comment: @mbutrovich updated. Will modify the core crate in a different PR to keep this in clean in scope; Core's `bit::ceil` references: ``` ❯ fd -e rs | xargs grep -Eir "bit::ceil\(| ceil\(" core/src/common/bit.rs:pub fn ceil(value: usize, divisor: usize) -> usize { core/src/common/bit.rs:/// Returns ceil(log2(x)) core/src/common/bit.rs: let num_bytes = ceil(self.bit_offset, 8); core/src/common/bit.rs: self.byte_offset - self.start + ceil(self.bit_offset, 8) core/src/common/bit.rs: self.byte_offset + ceil(self.bit_offset, 8) core/src/common/bit.rs: ((offset_i + 1)..(offset_i + ceil(n + offset_r, 8))).for_each(|i| { core/src/common/bit.rs: let bytes_read = ceil(self.bit_offset, 8); core/src/common/bit.rs: let num_bytes = ceil(num_bits, 8); core/src/common/bit.rs: let num_bytes = ceil(num_bits, 8); core/src/common/bit.rs: let num_bytes = ceil(num_bits, 8); core/src/common/bit.rs: let value_byte_width = ceil(num_bits, 8); core/src/parquet/mutable_vector.rs: let validity_len = bit::ceil(capacity, 8); core/src/parquet/mutable_vector.rs: let len = bit::ceil(value_capacity * bit_width, 8); core/src/parquet/read/levels.rs: let value_width = bit::ceil(self.bit_width as usize, 8); core/src/parquet/read/values.rs: let value_width = bit::ceil(self.bit_width, 8); ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
