alamb commented on PR #16632:
URL: https://github.com/apache/datafusion/pull/16632#issuecomment-3044933393

   > There are already some tests verifying the explain plans for the unnest 
plan. The scheduled run will currently fail.
   I'll adapt the 2 test failures
   
   Indeed the exising tests definitely seem to cover it -- you can see the 
reduction in projections
   
   ```
   2. query result mismatch:
   [SQL] explain select uc2 from (select unnest(column2) as uc2, column1 from 
v) where uc2 > 3;
   [Diff] (-expected|+actual)
       physical_plan
       01)ProjectionExec: expr=[__unnest_placeholder(v.column2,depth=1)@0 as 
uc2]
       02)--CoalesceBatchesExec: target_batch_size=8192
       03)----FilterExec: __unnest_placeholder(v.column2,depth=1)@0 > 3
       04)------RepartitionExec: partitioning=RoundRobinBatch(4), 
input_partitions=1
   -   05)--------ProjectionExec: 
expr=[__unnest_placeholder(v.column2,depth=1)@0 as 
__unnest_placeholder(v.column2,depth=1)]
   -   06)----------UnnestExec
   -   07)------------ProjectionExec: expr=[column2@1 as 
__unnest_placeholder(v.column2), column1@0 as column1]
   -   08)--------------DataSourceExec: partitions=1, partition_sizes=[1]
   +   05)--------UnnestExec
   +   06)----------ProjectionExec: expr=[column2@0 as 
__unnest_placeholder(v.column2)]
   +   07)------------DataSourceExec: partitions=1, partition_sizes=[1]
   at 
/home/runner/work/datafusion/datafusion/datafusion/sqllogictest/test_files/push_down_filter.slt:54
   
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org

Reply via email to