alamb commented on PR #16632: URL: https://github.com/apache/datafusion/pull/16632#issuecomment-3044638489
Thanks @bert-beyondloops -- sorry for the delay in review I started the CI tests The changes in this PR make sense to me -- the only thing I think it needs is some test to ensure we don't regress Can you please add some tests, ideally in sqllogicteset format? Here are the instructions: https://github.com/apache/datafusion/tree/main/datafusion/sqllogictest Ideally you should be able to extend one of the existing test files in https://github.com/apache/datafusion/tree/main/datafusion/sqllogictest/test_files Perhaps in https://github.com/apache/datafusion/blob/main/datafusion/sqllogictest/test_files/unnest.slt Specifically, I think an explain plan test that shows the projection being pushed down would be about all we need -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
