alamb commented on code in PR #16661:
URL: https://github.com/apache/datafusion/pull/16661#discussion_r2183732241
##########
datafusion/execution/src/config.rs:
##########
@@ -152,7 +157,7 @@ impl SessionConfig {
/// assert_eq!(config.options().execution.batch_size, 1024);
/// ```
pub fn options_mut(&mut self) -> &mut ConfigOptions {
- &mut self.options
+ Arc::make_mut(&mut self.options)
Review Comment:
> Previously the cost of options_mut was small, now it's considerable.
> Not sure it matters, but worth calling out.
Technically I think it is considerable only on the first call -- subsequent
calls will use the same copy (as I understand from the `make_mut` docs
https://doc.rust-lang.org/std/sync/struct.Arc.html#method.make_mut)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
