alamb opened a new pull request, #16661: URL: https://github.com/apache/datafusion/pull/16661
## Which issue does this PR close? - This is a possible alternative to https://github.com/apache/datafusion/pull/16573 from @findepi I think @Omega359 had other PRs as well Relates to - https://github.com/apache/datafusion/issues/12892 - https://github.com/apache/datafusion/issues/13519 - https://github.com/apache/datafusion/issues/13212 - https://github.com/apache/datafusion/issues/10368 ## Rationale for this change The need is to access configuration settings (such as the configured timezone) to scalar functions during planning - https://github.com/apache/datafusion/pull/16573 proposes copying just the timezone. This PR proposes copying a reference to the entire config ## What changes are included in this PR? Add an `Arc<ConfigOptions>` to ExecutionProps when the execution is started Things I am still not happy about: 1. This isn't with parity with UDFs yet as the entire SessionContext is saved there (not just config options) 2. It isn't passed all the way to ScalarUDFs ## Are these changes tested? <!-- We typically require tests for all PRs in order to: 1. Prevent the code from being accidentally broken by subsequent changes 3. Serve as another way to document the expected behavior of the code If tests are not included in your PR, please explain why (for example, are they covered by existing tests)? --> ## Are there any user-facing changes? <!-- If there are user-facing changes then we may require documentation to be updated before approving the PR. --> <!-- If there are any breaking changes to public APIs, please add the `api change` label. --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
