findepi commented on code in PR #16661:
URL: https://github.com/apache/datafusion/pull/16661#discussion_r2182030207
##########
datafusion/execution/src/config.rs:
##########
@@ -152,7 +157,7 @@ impl SessionConfig {
/// assert_eq!(config.options().execution.batch_size, 1024);
/// ```
pub fn options_mut(&mut self) -> &mut ConfigOptions {
- &mut self.options
+ Arc::make_mut(&mut self.options)
Review Comment:
Previously the cost of `options_mut` was small, now it's considerable.
Not sure it matters, but worth calling out.
##########
datafusion/expr/src/execution_props.rs:
##########
@@ -99,6 +104,12 @@ impl ExecutionProps {
.as_ref()
.and_then(|var_providers| var_providers.get(&var_type).cloned())
}
+
+ /// Returns the configuration properties for this execution
+ /// if the execution has started
+ pub fn config_options(&self) -> Option<&Arc<ConfigOptions>> {
Review Comment:
the `with_query_execution_start_time` makes / used to make ExecutionProps
"as started"
these call sites should be updated as well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
