Omega359 commented on issue #16577:
URL: https://github.com/apache/datafusion/issues/16577#issuecomment-3025061285

   > Right now it is
   > 
   > ```
   > from_unixtime(expression[, timezone])
   > ```
   > 
   > So I guess it will be like
   > 
   > ```
   > from_unixtime(expression[, fmt, timezone])
   > ```
   
   If you did that you would (possibly silently) break any existing usages of 
from_unixtime(expression, timezone). If you did that you would have to somehow 
infer the second arg to be either a timezone or a format. Not terribly hard but 
it's not what I would recommend. 
   
   You could do from_unixtime(expression[, timezone, fmt]) however. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org

Reply via email to