ianthetechie commented on code in PR #16646:
URL: https://github.com/apache/datafusion/pull/16646#discussion_r2178808025
##########
datafusion/datasource-parquet/src/source.rs:
##########
@@ -625,7 +623,13 @@ impl FileSource for ParquetSource {
let Some(file_schema) = self.file_schema.clone() else {
return Ok(FilterPushdownPropagation::unsupported(filters));
};
- // Can we push down the filters themselves into the scan or only use
stats pruning?
+ // Determine if based on configs we should push filters down.
+ // If either the table / scan itself or the config has pushdown
enabled,
+ // we will push down the filters.
+ // If both are disabled, we will not push down the filters.
+ // By default they are both disabled.
+ // Regardless of pushdown, we will update the predicate to include the
filters
+ // because even if scan pushdown is disabled we can still use the
filters for stats pruning.
Review Comment:
I had wondered about this; thanks for updating this comment!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
