adriangb commented on PR #16646:
URL: https://github.com/apache/datafusion/pull/16646#issuecomment-3025642930
I can confirm this new test fails without the change:
```
❯ cargo test -p datafusion-sqllogictest --test sqllogictests --
parquet_filter_pushdown
Compiling datafusion-datasource-parquet v48.0.0
(/Users/adriangb/GitHub/datafusion-clone/datafusion/datasource-parquet)
Compiling datafusion v48.0.0
(/Users/adriangb/GitHub/datafusion-clone/datafusion/core)
Compiling datafusion-substrait v48.0.0
(/Users/adriangb/GitHub/datafusion-clone/datafusion/substrait)
Compiling datafusion-sqllogictest v48.0.0
(/Users/adriangb/GitHub/datafusion-clone/datafusion/sqllogictest)
Finished `test` profile [unoptimized + debuginfo] target(s) in 4.69s
Running bin/sqllogictests.rs
(target/debug/deps/sqllogictests-5b94bf3a17202ad3)
Completed 1 test files in 0 seconds
External error: 1 errors in file
/Users/adriangb/GitHub/datafusion-clone/datafusion/sqllogictest/test_files/parquet_filter_pushdown.slt
1. query result mismatch:
[SQL] select a from t where b > 2 ORDER BY a;
[Diff] (-expected|+actual)
+ bar
baz
foo
+ foo
NULL
NULL
NULL
at
/Users/adriangb/GitHub/datafusion-clone/datafusion/sqllogictest/test_files/parquet_filter_pushdown.slt:120
Error: Execution("1 failures")
error: test failed, to rerun pass `-p datafusion-sqllogictest --test
sqllogictests`
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
