corwinjoy commented on code in PR #16351:
URL: https://github.com/apache/datafusion/pull/16351#discussion_r2168078769
##########
datafusion/proto-common/src/from_proto/mod.rs:
##########
@@ -1066,6 +1066,7 @@ impl TryFrom<&protobuf::TableParquetOptions> for
TableParquetOptions {
.unwrap(),
column_specific_options,
key_value_metadata: Default::default(),
+ crypto: Default::default(),
Review Comment:
Should we? I see that `key_value_metadata` is always set to empty here
despite being defined in datafusion/proto-common/src/generated/prost.rs. So,
it's not clear to me that we should throw an error here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
