corwinjoy commented on PR #16351: URL: https://github.com/apache/datafusion/pull/16351#issuecomment-3003280082
> Thank you @corwinjoy and @adamreeve -- this PR was a joy to read and review. The code is clear, well commented, and well tested ❤️ 🏆 > > I think we should follow up with: > > 1. Improve the documentation to include the format required for encryption/decryption properties > 2. Consider adding a `encyrption` or similar feature flag so people who don't want support for parquet encryption can avoid bringing along the dependencies Thanks @alamb !! I have added a commit to improve the documentation and add a CLI example. (I could use some feedback on where to put the CLI example.) I will start looking into adding an `encryption` feature tomorrow. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
