goldmedal commented on code in PR #16523:
URL: https://github.com/apache/datafusion/pull/16523#discussion_r2164074452
##########
datafusion-examples/examples/async_udf.rs:
##########
@@ -243,9 +252,20 @@ impl AsyncScalarUDFImpl for AsyncEqual {
Ok(DataType::Boolean)
}
+ fn invoke_with_args(
+ &self,
+ _args: ScalarFunctionArgs,
+ ) -> Result<ColumnarValue> {
+ not_impl_err!("AsyncEqual can only be called from async contexts")
+ }
+}
+
+#[async_trait]
+ impl AsyncScalarUDFImpl for AsyncEqual {
+
async fn invoke_async_with_args(
&self,
- args: AsyncScalarFunctionArgs,
+ args: ScalarFunctionArgs,
Review Comment:
It makes sense to me. We allow the custom config. Allowing access to the
config option can make UDF flexible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
