alamb commented on code in PR #16523:
URL: https://github.com/apache/datafusion/pull/16523#discussion_r2162390807
##########
datafusion/expr/src/async_udf.rs:
##########
@@ -35,34 +35,7 @@ use std::sync::Arc;
///
/// The name is chosen to mirror ScalarUDFImpl
#[async_trait]
-pub trait AsyncScalarUDFImpl: Debug + Send + Sync {
- /// the function cast as any
- fn as_any(&self) -> &dyn Any;
Review Comment:
The point of this PR is to remove this duplication from `AsyncScalarUDFImpl`
and instead use ScalarUDFImpl instead
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
