alamb opened a new pull request, #16523:
URL: https://github.com/apache/datafusion/pull/16523

   ## Which issue does this PR close?
   
   <!--
   We generally require a GitHub issue to be filed for all bug fixes and 
enhancements and this helps us generate change logs for our releases. You can 
link an issue to this PR using the GitHub syntax. For example `Closes #123` 
indicates that this PR will close issue #123.
   -->
   
   - Closes https://github.com/apache/datafusion/issues/16522
   
   ## Rationale for this change
   
   Following @berkaysynnada 's suggestion in 
https://github.com/apache/datafusion/pull/14837 having parallel implementations 
of functions allows sync and async UDFs to drift apart. 
   
   Let's try and make the differences as small as possible
   
   ## What changes are included in this PR?
   
   1. Make Avoid duplication of AsyncUDFImpl  and instead use the same 
structures for `ScalarUdfImpl`
   2. Update examples to match
   
   ## Are these changes tested?
   
   <!--
   We typically require tests for all PRs in order to:
   1. Prevent the code from being accidentally broken by subsequent changes
   3. Serve as another way to document the expected behavior of the code
   
   If tests are not included in your PR, please explain why (for example, are 
they covered by existing tests)?
   -->
   
   ## Are there any user-facing changes?
   
   API is changed, but it has not been released uet
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org

Reply via email to