alamb commented on code in PR #15769:
URL: https://github.com/apache/datafusion/pull/15769#discussion_r2163543672
##########
datafusion/datasource/src/file_format.rs:
##########
@@ -94,7 +93,6 @@ pub trait FileFormat: Send + Sync + fmt::Debug {
&self,
state: &dyn Session,
conf: FileScanConfig,
- filters: Option<&Arc<dyn PhysicalExpr>>,
Review Comment:
I feel ilke we have done this a few times now @xudong963 (broken some APIs
you are relying on heavily)
I wonder if there is some way to make a tests / example that illustrates
what you are doing? That would have some benefits:
1. it would illustrate exactly the way the API needs to be changed on upgrade
2. it would make it clearer when changes to APIs have impacts on you (and
other's usecases)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
