xudong963 commented on code in PR #15769: URL: https://github.com/apache/datafusion/pull/15769#discussion_r2163133150
########## datafusion/datasource/src/file_format.rs: ########## @@ -94,7 +93,6 @@ pub trait FileFormat: Send + Sync + fmt::Debug { &self, state: &dyn Session, conf: FileScanConfig, - filters: Option<&Arc<dyn PhysicalExpr>>, Review Comment: This is definitely a breaking API change, we depend on the interface intensively 😢 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org