adriangb commented on code in PR #16461:
URL: https://github.com/apache/datafusion/pull/16461#discussion_r2159713329
##########
datafusion/datasource-parquet/src/row_filter.rs:
##########
@@ -520,111 +489,15 @@ mod test {
let expr = col("int64_list").is_not_null();
let expr = logical2physical(&expr, &table_schema);
- let schema_adapter_factory = Arc::new(DefaultSchemaAdapterFactory);
let table_schema = Arc::new(table_schema.clone());
- let candidate = FilterCandidateBuilder::new(
- expr,
- table_schema.clone(),
- table_schema,
- schema_adapter_factory,
- )
- .build(metadata)
- .expect("building candidate");
+ let candidate = FilterCandidateBuilder::new(expr, table_schema.clone())
+ .build(metadata)
+ .expect("building candidate");
assert!(candidate.is_none());
}
- #[test]
- fn test_filter_type_coercion() {
Review Comment:
I think so - I'll have to make it more e2e since it is no longer specific to
the row filter. We have some other similar tests, I'll work this into there
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
