adriangb opened a new pull request, #16461: URL: https://github.com/apache/datafusion/pull/16461
The idea here is to move us one step closer to https://github.com/apache/datafusion/issues/15780 although there is still work to do (e.g. https://github.com/apache/datafusion/issues/15780#issuecomment-2824716928). Note that this *mostly* replaces the need for this SchemaAdapter: https://github.com/pydantic/datafusion/blob/d15957bc0b32d918b44e07814b7061c620b00473/datafusion/datasource-parquet/src/row_filter.rs#L146 But I'll leave it in to: 1. Avoid code / public API churn. 2. Since it's a `dyn` in theory users could pass in a custom factory to [build_row_filter](https://github.com/pydantic/datafusion/blob/d15957bc0b32d918b44e07814b7061c620b00473/datafusion/datasource-parquet/src/row_filter.rs#L426) that does arbitrary things and removing it would leave them with no recourse (I don't think anyone is using this fwiw). 3. When not doing any conversions it adds very little overhead. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
