andygrove commented on code in PR #16350:
URL: https://github.com/apache/datafusion/pull/16350#discussion_r2138607063
##########
datafusion/spark/src/function/math/hex.rs:
##########
@@ -192,7 +195,7 @@ pub fn spark_hex(args: &[ColumnarValue]) ->
Result<ColumnarValue, DataFusionErro
let hexed: StringArray = array
.iter()
- .map(|v| v.map(hex_bytes).transpose())
+ .map(|v| v.map(|b| hex_bytes(b, true)).transpose())
Review Comment:
Sorry, I meant that we should have seen test failures in DataFusion after
changing the hex behavior. It looks like we should add an slt test for hex as
well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
