rishvin commented on code in PR #16350: URL: https://github.com/apache/datafusion/pull/16350#discussion_r2138403551
########## datafusion/spark/src/function/math/hex.rs: ########## @@ -192,7 +195,7 @@ pub fn spark_hex(args: &[ColumnarValue]) -> Result<ColumnarValue, DataFusionErro let hexed: StringArray = array .iter() - .map(|v| v.map(hex_bytes).transpose()) + .map(|v| v.map(|b| hex_bytes(b, true)).transpose()) Review Comment: Thanks @getChan for pointing this out. In that case, I will make change for SHA2 hex representation only. Here is one example from spark-shell of SHA2, ``` scala> spark.sql("SELECT sha2('abc', 256) AS sha256_value").show(false) +----------------------------------------------------------------+ |sha256_value | +----------------------------------------------------------------+ |ba7816bf8f01cfea414140de5dae2223b00361a396177a9cb410ff61f20015ad| +----------------------------------------------------------------+ ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org