mbutrovich commented on code in PR #1862: URL: https://github.com/apache/datafusion-comet/pull/1862#discussion_r2138343547
########## native/core/benches/shuffle_writer.rs: ########## @@ -66,10 +67,40 @@ fn criterion_benchmark(c: &mut Criterion) { CompressionCodec::Zstd(6), ] { group.bench_function( - format!("shuffle_writer: end to end (compression = {compression_codec:?}"), + format!("shuffle_writer: end to end (compression = {compression_codec:?})"), + |b| { + let ctx = SessionContext::new(); + let exec = create_shuffle_writer_exec( + compression_codec.clone(), + CometPartitioning::Hash(vec![Arc::new(Column::new("a", 0))], 16), + ); + b.iter(|| { + let task_ctx = ctx.task_ctx(); + let stream = exec.execute(0, task_ctx).unwrap(); + let rt = Runtime::new().unwrap(); + rt.block_on(collect(stream)).unwrap(); + }); + }, + ); + } + + for partitioning in [ + CometPartitioning::Hash(vec![Arc::new(Column::new("a", 0))], 16), + CometPartitioning::RangePartitioning( Review Comment: Added RangePartitioning benchmark here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org