mbutrovich commented on code in PR #1862: URL: https://github.com/apache/datafusion-comet/pull/1862#discussion_r2135992681
########## native/core/benches/shuffle_writer.rs: ########## @@ -42,20 +45,18 @@ fn criterion_benchmark(c: &mut Criterion) { CompressionCodec::Zstd(1), CompressionCodec::Zstd(6), ] { - for enable_fast_encoding in [true, false] { Review Comment: Remove this `enable_fast_encoding` loop since we don't have that flag anymore after #1703. ########## native/core/benches/shuffle_writer.rs: ########## @@ -42,20 +45,18 @@ fn criterion_benchmark(c: &mut Criterion) { CompressionCodec::Zstd(1), CompressionCodec::Zstd(6), ] { - for enable_fast_encoding in [true, false] { Review Comment: Removed this `enable_fast_encoding` loop since we don't have that flag anymore after #1703. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org