ozankabak commented on code in PR #16217:
URL: https://github.com/apache/datafusion/pull/16217#discussion_r2126721050
##########
datafusion/physical-expr-common/src/sort_expr.rs:
##########
@@ -159,38 +200,17 @@ impl Display for PhysicalSortExpr {
}
}
-impl PhysicalSortExpr {
- /// evaluate the sort expression into SortColumn that can be passed into
arrow sort kernel
- pub fn evaluate_to_sort_column(&self, batch: &RecordBatch) ->
Result<SortColumn> {
- let value_to_sort = self.expr.evaluate(batch)?;
- let array_to_sort = match value_to_sort {
- ColumnarValue::Array(array) => array,
- ColumnarValue::Scalar(scalar) =>
scalar.to_array_of_size(batch.num_rows())?,
- };
- Ok(SortColumn {
- values: array_to_sort,
- options: Some(self.options),
- })
- }
-
- /// Checks whether this sort expression satisfies the given `requirement`.
- /// If sort options are unspecified in `requirement`, only expressions are
- /// compared for inequality.
- pub fn satisfy(
- &self,
- requirement: &PhysicalSortRequirement,
- schema: &Schema,
- ) -> bool {
+/// Returns whether the given two [`SortOptions`] are compatible.
Review Comment:
Agreed, will add a remark to the docstring.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
